GH-49942: [Python] Protect PyBuffer and NumPyBuffer destructors against interpreter finalization - #49943
Merged
Merged
Conversation
… against interpreter finalization
Member
Author
|
@github-actions crossbow submit -g python |
|
Revision: bbe7634 Submitted crossbow builds: ursacomputing/crossbow @ actions-62ce37605c
|
Member
Author
|
@github-actions crossbow submit wheelmac* wheelwin* |
|
Revision: bbe7634 Submitted crossbow builds: ursacomputing/crossbow @ actions-62ea8dd650
|
github-actions
Bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit d4e0e26. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit d4e0e26. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
… against interpreter finalization (apache#49943) ### Rationale for this change In apache#38637 we protected the `OwnedRef` and `OwnedRefNoGIL` destructors against being called when the Python interpreter is being finalized, but we didn't address other classes with custom destructors, such as `PyBuffer` and `NumPyBuffer`. ### What changes are included in this PR? Avoid executing Python C API code if the interpreter is finalized while a C++ destructor runs. ### Are these changes tested? Only manually, using the initial reproducer in apache#45214. ### Are there any user-facing changes? No. * GitHub Issue: apache#49942 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In #38637 we protected the
OwnedRefandOwnedRefNoGILdestructors against being called when the Python interpreter is being finalized, but we didn't address other classes with custom destructors, such asPyBufferandNumPyBuffer.What changes are included in this PR?
Avoid executing Python C API code if the interpreter is finalized while a C++ destructor runs.
Are these changes tested?
Only manually, using the initial reproducer in #45214.
Are there any user-facing changes?
No.